Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#82 ModularParser-getLanguages()-returns-null #276

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 15, 2023

#82 ModularParser-getLanguages()-returns-null

  • adjusts ModularParser to return empty instead of null in line 496ff to avoid NPEs
  • adds new test to ParsedPageTest verifying a parse of plain/raw mediawiki articles as reported in the issue
  • fixes naming of misspelled method or field names
  • fixes (many weird) typos
  • adjusts JavaDoc along the path

What's in the PR

How to test manually

  • mvn clean test

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

Resolves #82.

- adjusts `ModularParser` to return empty instead of `null` in line 496ff to avoid NPEs
- adds new test to `ParsedPageTest` verifying a parse of plain/raw mediawiki articles as reported in #82
- fixes naming of misspelled method or field names
- fixes (many weird) typos
- adjusts JavaDoc along the path
- partially resolves #82
@mawiesne mawiesne added this to the 2.0.0 milestone Nov 15, 2023
@mawiesne mawiesne requested a review from rzo1 November 15, 2023 07:33
@mawiesne mawiesne self-assigned this Nov 15, 2023
@mawiesne mawiesne merged commit c7b843a into master Nov 15, 2023
4 checks passed
@mawiesne mawiesne deleted the #82-ModularParser-getLanguages()-returns-null branch November 15, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModularParser getLanguages() returns null
2 participants